Updates sdlscancode.inc and sdlkeycode.inc to 2.26.2 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Free-Pascal-meets-SDL-Website
commented
Jan 27, 2023
Free-Pascal-meets-SDL-Website
commented
- updates sdlscancode.inc to version 2.26.2
- moves translated code from SDL_keycode.h from sdlscancode.inc into separate, new file sdlkeycode.inc
- updates sdlkeycode.inc to version 2.26.2
suve
approved these changes
Jan 31, 2023
|
|
||
| const | ||
| SDLK_SCANCODE_MASK = 1 shl 30; | ||
| //#define SDL_SCANCODE_TO_KEYCODE(X) (X | SDLK_SCANCODE_MASK) |
Collaborator
There was a problem hiding this comment.
Should we define this as a Pascal function?
Collaborator
Author
There was a problem hiding this comment.
I prefer to keep it as is, because a function call has a little more overhead compared to just reading a constant value. Since scancodes may be requested in a large amount and rapidly, this means a large amount of function calls would result.
A second point why I opt'ed for keeping it as is, it saved some time :-).
Feel free to merge this if you approve my answer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.